Skip to content

fix: resolve workspace preview styling and mobile login modal positio… #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
velonone merged 1 commit into from
Feb 6, 2026
+197 −4
Merged

fix: resolve workspace preview styling and mobile login modal positio… #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/app/components/OAuthConfirmModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,13 @@ export function OAuthConfirmModal({
top: '50%',
left: '50%',
transform: 'translate(-50%, -50%)',
width: 'calc(100% - 32px)',
maxWidth: '420px',
maxHeight: 'calc(100vh - 48px)',
width: 'min(calc(100vw - 32px), 420px)',
maxHeight: 'calc(100dvh - 48px)',
overflowY: 'auto',
background: '#FFFFFF',
borderRadius: '16px',
boxShadow: '0 20px 60px rgba(0, 0, 0, 0.2)',
zIndex: 1001,
margin: '0 16px',
}}
>
{/* Header */}
Expand Down
42 changes: 42 additions & 0 deletions src/styles/responsive.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,3 +521,45 @@
min-width: 100px !important;
}
}

/* ===============================================
MODAL MOBILE RESPONSIVE FIXES
=============================================== */

/* Ensure all fixed position modals are properly centered on mobile */
@media (max-width: 767px) {
/* Generic modal centering fix */
[style*="position: fixed"][style*="transform: translate(-50%, -50%)"] {
width: calc(100vw - 32px) !important;
max-width: 420px !important;
max-height: calc(100dvh - 48px) !important;
margin: 0 !important;
}

/* Login page on mobile - stack columns */
.login-page-grid {
display: flex !important;
flex-direction: column !important;
gap: 32px !important;
}

/* Ensure modal backdrop covers entire viewport including PWA status bar */
.modal-backdrop {
position: fixed !important;
top: 0 !important;
left: 0 !important;
right: 0 !important;
bottom: 0 !important;
width: 100vw !important;
height: 100vh !important;
height: 100dvh !important;
}
}

/* PWA specific modal fixes */
@media (display-mode: standalone) {
/* Ensure modals account for PWA safe areas */
[style*="position: fixed"][style*="top: '50%'"] {
top: max(50%, env(safe-area-inset-top, 0px)) !important;
}
Comment on lines +560 to +564
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

PWA selector won’t match due to quoted value.

Inline styles render as top: 50%, so [style*="top: '50%'"] will never match. This prevents the safe‑area adjustment from applying in PWA mode.

🔧 Proposed fix 
-  [style*="position: fixed"][style*="top: '50%'"] {
+  [style*="position: fixed"][style*="top: 50%"] {
     top: max(50%, env(safe-area-inset-top, 0px)) !important;
   }
🤖 Prompt for AI Agents 
In `@src/styles/responsive.css` around lines 560 - 564, The PWA-safe-area selector
is using a quoted top value and never matches inline styles; update the selector
inside the `@media` (display-mode: standalone) rule so it matches actual inline
styles by replacing the attribute selector [style*="top: '50%'"] with an
unquoted variant that covers common formatting (e.g., [style*="top: 50%"] and/or
[style*="top:50%"]) while keeping the existing [style*="position: fixed"]
condition and the top: max(...) adjustment in the same rule.

}
153 changes: 153 additions & 0 deletions src/styles/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,159 @@
PROSE EDITOR STYLES
============================================ */

/* Base prose styling for document preview */
.prose {
color: var(--color-text-primary);
max-width: 65ch;
line-height: 1.75;
}

.prose-lg {
font-size: 1.125rem;
line-height: 1.8;
}

.prose h1 {
font-size: 2.25rem;
font-weight: 800;
margin-top: 0;
margin-bottom: 0.8em;
line-height: 1.1;
color: var(--color-text-primary);
}

.prose h2 {
font-size: 1.5rem;
font-weight: 700;
margin-top: 2em;
margin-bottom: 1em;
line-height: 1.3;
color: var(--color-text-primary);
}

.prose h3 {
font-size: 1.25rem;
font-weight: 600;
margin-top: 1.6em;
margin-bottom: 0.6em;
line-height: 1.4;
color: var(--color-text-primary);
}

.prose p {
margin-top: 1.25em;
margin-bottom: 1.25em;
color: inherit;
}

.prose a {
color: var(--color-primary);
text-decoration: underline;
}

.prose strong {
font-weight: 600;
color: inherit;
}

.prose em {
font-style: italic;
}

.prose ul {
list-style-type: disc;
margin-top: 1.25em;
margin-bottom: 1.25em;
padding-left: 1.625em;
}

.prose ol {
list-style-type: decimal;
margin-top: 1.25em;
margin-bottom: 1.25em;
padding-left: 1.625em;
}

.prose li {
margin-top: 0.5em;
margin-bottom: 0.5em;
color: inherit;
}

.prose blockquote {
font-style: italic;
border-left: 4px solid var(--color-primary);
margin-top: 1.6em;
margin-bottom: 1.6em;
padding-left: 1em;
color: var(--color-text-secondary);
}

.prose code {
font-family: var(--font-mono);
font-size: 0.875em;
background: var(--color-primary-bg);
padding: 0.2em 0.4em;
border-radius: var(--radius-sm);
color: var(--color-primary);
}

.prose pre {
overflow-x: auto;
background: #1e293b;
border-radius: var(--radius-lg);
padding: 1rem;
margin-top: 1.7em;
margin-bottom: 1.7em;
}

.prose pre code {
background: transparent;
padding: 0;
color: #e2e8f0;
font-size: 0.875em;
}

.prose img {
margin-top: 2em;
margin-bottom: 2em;
border-radius: var(--radius-lg);
max-width: 100%;
height: auto;
}

.prose hr {
border-color: var(--color-border);
margin-top: 3em;
margin-bottom: 3em;
}

.prose table {
width: 100%;
table-layout: auto;
text-align: left;
margin-top: 2em;
margin-bottom: 2em;
border-collapse: collapse;
}

.prose th {
font-weight: 600;
padding: 0.75em 1em;
border-bottom: 2px solid var(--color-border);
color: var(--color-text-primary);
}

.prose td {
padding: 0.75em 1em;
border-bottom: 1px solid var(--color-border);
}

/* max-w-none utility */
.max-w-none {
max-width: none;
}

.ProseMirror,
.rich-text-editor-content {
color: var(--color-text-primary);
Expand Down