Skip to content

chore: sync FPF spec from ailev/FPF (2026-05-23)#138

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
chore/sync-fpf-04dd733f
Open

chore: sync FPF spec from ailev/FPF (2026-05-23)#138
github-actions[bot] wants to merge 1 commit into
mainfrom
chore/sync-fpf-04dd733f

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Auto-detected new commit on ailev/FPF main.

CI gates this merge: lint, type, tests, hosted MCP build, Vercel preview deploy, and Playwright E2E. After a two-hour review window, the sync workflow will merge this PR automatically if every reported check/status is passing.

Generated by .github/workflows/sync-fpf.yml. Failed or still-pending checks leave this PR open for manual review.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fpf-sh Ready Ready Preview, Comment May 26, 2026 7:09am

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c158e93f3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +1282 to +1284
"slug": "boundary-unpacking-and-claim-decomposition",
"title": "Boundary unpacking and claim decomposition",
"staticPath": "/generated/routes/route_boundary-unpacking-and-claim-decomposition"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve alias for renamed boundary-claim route

This rename removes route:boundary-unpacking-claim-routing from the generated route set, but runtime logic still hard-codes that ID in scoreAdoptionRouteIntent (src/runtime/query-helpers.ts) and in routeAcceptanceCheck/routeNextMove (src/runtime/answer-projector.ts). After this sync, those route-specific boosts and answer templates no longer trigger for boundary-review queries, which can change ranking and degrade guidance. Add an old→new route-ID alias (or update all hard-coded references in the same change) to avoid this regression.

Useful? React with 👍 / 👎.

Comment on lines +1267 to +1269
"slug": "admissible-comparison-candidate-pool-policy-selection-and-selected-set-publication",
"title": "Admissible comparison, candidate-pool policy, selection, and selected-set publication",
"staticPath": "/generated/routes/route_admissible-comparison-candidate-pool-policy-selection-and-selected-set-publication"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep compatibility for renamed comparison route IDs

This sync replaces earlier comparison route IDs with new slugs, but user-facing docs still reference removed IDs (for example route:lawful-comparison-pool-selection-selected-set-publication in docs/start-here.md). Since explicit route selectors only work for IDs present in the registry/snapshot, those documented selectors now fail to resolve. Please provide backward-compatible aliases for renamed route IDs or update all documented selectors atomically with this data refresh.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68fb8df9cb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +1282 to +1284
"slug": "boundary-unpacking-and-claim-decomposition",
"title": "Boundary unpacking and claim decomposition",
"staticPath": "/generated/routes/route_boundary-unpacking-and-claim-decomposition"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep boundary route selector backward-compatible

The route registry now removes route:boundary-unpacking-claim-routing and replaces it with route:boundary-unpacking-and-claim-decomposition, but user docs still instruct the old selector in docs/work-packets.md:50 and docs/mcp-recipes.md:98; because route lookup is exact by slug (ROUTE_BY_SLUG in src/docs/search-hooks.ts:66-67, matched at :114-116), those documented commands no longer resolve to a canonical route page after this sync. Please add an alias for the old slug or update these docs in the same change so guided review flows keep working.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants