Skip to content

chore: add required measurable impact verification to issue and PR templates #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
venikman wants to merge 2 commits into from
Closed

chore: add required measurable impact verification to issue and PR templates #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6216f3e
chore: add required measurable impact verification to issue and PR te…
devin-ai-integration[bot] Apr 13, 2026
adbd24e
fix: correct placeholder example in feature request template per Copi…
devin-ai-integration[bot] Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,21 @@ body:
validations:
required: false

- type: textarea
id: impact
attributes:
label: Measurable impact verification
description: |
How will we verify the fix works and measure its impact? Provide a table with concrete metrics.
Every metric must be quantifiable — no vague criteria like "works better" or "improved".
placeholder: |
| Metric | Before (broken) | After (target) | How to measure |
|--------|-----------------|----------------|----------------|
| Error on query X | throws TypeError | returns valid answer | `bun run cli -- query --question "X"` |
| Test pass rate | 38/39 (1 failure) | 39/39 | `bun run test` |
validations:
required: true

- type: textarea
id: context
attributes:
Expand Down
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,21 @@ body:
validations:
required: true

- type: textarea
id: impact
attributes:
label: Measurable impact verification
description: |
How will we verify the feature works and measure its impact? Provide a table with concrete metrics.
Every metric must be quantifiable — no vague criteria like "works better" or "improved".
placeholder: |
| Metric | Before | After (target) | How to measure |
|--------|--------|----------------|----------------|
| Total MCP tool definitions | 10 | 12 | `grep -c createTool src/mcp/tools.ts` |
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The example command references src/mcp/tools.ts, but the project's boundary checks (as defined in the PR template, line 45) specify that MCP tool contracts should reside in src/mcp/tool-contracts.ts. Updating the example to use the correct file path maintains consistency with the project's established structure.

        | New MCP tools available | 0 | 2 | `grep -c createTool src/mcp/tool-contracts.ts` |

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false positive. The boundary check says "MCP tool contracts stay in src/mcp/tool-contracts.ts" — meaning Zod input/output schemas. The actual createTool calls live in src/mcp/tools.ts:

$ grep -c createTool src/mcp/tools.ts
10
$ grep -c createTool src/mcp/tool-contracts.ts
0

The example correctly references tools.ts for counting tool definitions.

| Feature test cases added | 0 | ≥5 | `grep -Ec '\b(it|test)\(' tests/feature.test.ts` |
validations:
required: true

- type: textarea
id: alternatives
attributes:
Expand Down
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE/task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,21 @@ body:
validations:
required: false

- type: textarea
id: impact
attributes:
label: Measurable impact verification
description: |
How will we verify the task is complete and measure its impact? Provide a table with concrete metrics.
Every metric must be quantifiable — no vague criteria like "works better" or "improved".
placeholder: |
| Metric | Before | After (target) | How to measure |
|--------|--------|----------------|----------------|
| LOC in target file | 1614 | ≤400 | `wc -l src/runtime/target.ts` |
| Existing test pass rate | all pass | all pass | `bun run test` |
validations:
required: true

- type: dropdown
id: agent_delegable
attributes:
Expand Down
9 changes: 9 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@

<!-- Key changes, one bullet per logical unit -->

## Measurable impact verification

<!-- Required. Provide a table showing before/after metrics that prove this PR's impact.
Every metric must be quantifiable — no vague criteria like "works better" or "improved". -->

| Metric | Before | After (target) | How to measure |
|--------|--------|----------------|----------------|
| <!-- e.g. LOC in target file --> | <!-- e.g. 1614 --> | <!-- e.g. ≤400 --> | <!-- e.g. `wc -l src/runtime/target.ts` --> |

## Validation

- [ ] `bun run lint` passes locally
Expand Down
Loading