Run the support script via a less opinionated shell#47
Draft
Run the support script via a less opinionated shell#47
Conversation
- vars can still be defined/overridden on the template level (add this to the readme to clarify)
aharpervc
force-pushed
the
env-block-vars
branch
from
095fecb to
379c70f
Compare
aharpervc
force-pushed
the
env-block-vars
branch
from
379c70f to
3735f0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everybody has a "sh", but not everybody uses bash. The script file itself seems to work fine,
I don't think we were using any bash-isms anyway.actually, the$"is a bash-ism, so populate_consul.sh will also need to be updated if this is accepted.