Accept RegExp needles in toContainText#174
Merged
Merged
Conversation
gaojude
marked this pull request as ready for review
July 17, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toContainTextneedles can now be a RegExp as well as an exact substring, so/getserversideprops/icatches any casing and an escaped-form pattern can match through the JSONL encoding. Global and sticky flags are stripped before matching so a reusedgregex cannot skip matches vialastIndex, and a pattern that matches the empty string throws, since it would make the assertion vacuous under.not.