fix: give a clear, non-retrying error when the bundled Codex binary is missing#101
Open
mvanhorn wants to merge 1 commit into
Open
fix: give a clear, non-retrying error when the bundled Codex binary is missing#101mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
…s missing/quarantined Fixes vercel-labs#100
|
@mvanhorn is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the vendored
@openai/codexbinary is removed or quarantined (macOS Gatekeeper can SIGKILL then remove it), the SDK spawn fails withENOENTand the processor retried it as a transient error, producing a confusing "no result after N attempts".Changes
Detect the missing-binary signature (
ENOENT/no-such-file combined with the vendored@openai/codex/.../codexpath) and surface a clear, actionable error that names the missing path and the quarantine fix (xattr -dr com.apple.quarantine ...) instead of retrying.Testing
Added tests in
packages/processor/src/__tests__/shared.test.tsfor the classifier and formatter (positive and negative cases).Fixes #100