Skip to content

[codex] Fix bundle e2e symlink cleanup#99

Draft
brandonbryant12 wants to merge 1 commit into
vercel-labs:mainfrom
brandonbryant12:codex/codex-integration-fixes
Draft

[codex] Fix bundle e2e symlink cleanup#99
brandonbryant12 wants to merge 1 commit into
vercel-labs:mainfrom
brandonbryant12:codex/codex-integration-fixes

Conversation

@brandonbryant12

Copy link
Copy Markdown

Summary

  • Fix the bundle e2e sample cleanup so directory symlinks are unlinked safely.
  • Preserve real sample-local node_modules directories while cleaning generated symlinks and data.

Root cause

The samples/webapp bundle e2e test creates a node_modules symlink so the sample config can resolve deepsec/config. Its cleanup used fs.rmSync(link, { force: true }), which can throw Path is a directory for a directory symlink, leaving ignored sample artifacts behind and failing the suite.

Validation

  • pnpm exec vitest run --project e2e e2e/bundle.test.ts -t "samples/webapp"
  • pnpm deepsec process --diff origin/main --agent codex --no-ignore --concurrency 1 --batch-size 1 --comment-out tmp/deepsec-codex-comment.md (1 analysis, 0 findings)
  • pnpm validate

Review

  • Thermonuclear code review pass: scoped to one test file, no production surface change, no structural regression found.

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

@brandonbryant12 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant