Support Laravel port injection#331
Open
nguyenphutrong wants to merge 2 commits into
Open
Conversation
|
@nguyenphutrong is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
nguyenphutrong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PORT.--port <assigned-port>and--host 127.0.0.1for Laravel dev server commands.Validation
pnpm exec vitest run src/cli-utils.test.ts -t injectFrameworkFlagspnpm type-checkpnpm exec prettier --check ../../README.md ../../skills/portless/SKILL.md ../../apps/docs/src/app/configuration/page.mdx ../../apps/docs/src/app/page.mdx src/cli-utils.ts src/cli-utils.test.ts src/cli.tspnpm buildpnpm --filter @portless/docs buildnode packages/portless/dist/cli.js --help | rg -n 'Frameworks that ignore PORT|Laravel'Note
pnpm exec vitest run src/cli-utils.test.tsstill has one unrelated local failure in the LAN marker test because127.0.0.1:1355is listening in this environment, sodiscoverState()treats the marker as active and returns the LAN IP.