fix: remove broken extern c from config-shape, add missing use types#231
Open
bradhallett wants to merge 1 commit into
Open
fix: remove broken extern c from config-shape, add missing use types#231bradhallett wants to merge 1 commit into
bradhallett wants to merge 1 commit into
Conversation
…to helpers - examples/config-shape.0: Remove 'extern c "stdint.h"' and 'extern type CConfig' blocks that fail with CIMP001 (header not readable). The pure-Zero Config type and main function remain intact and now pass 'zero check --json'. - examples/systems-package/src/helpers.0: Add 'use types' import so the Status type is resolved when the file is checked in isolation. The package already passed at the package level; this makes the individual file check cleaner. Note: 14 package library files (src/*.0 in multi-file packages) still report APP001 when checked individually — this is expected since they are library modules, not standalone programs. They all pass when checked as packages (e.g., 'bin/zero check --json examples/resource-cli').
bradhallett
force-pushed
the
fix/stale-examples
branch
from
df801a2 to
7b89756
Compare
|
@bradhallett is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two broken examples that fail
zero checkon current main:examples/config-shape.0: Remove brokenextern cdeclarations that cause CGEN004 (unsupported backend type). Theexternsyntax for C FFI is not supported by the direct Mach-O backend.examples/systems-package/src/helpers.0: Add missinguse typesimport needed forStatustype resolution.Validation
Changes
examples/config-shape.0: Removed 6 lines (extern c, extern type)examples/systems-package/src/helpers.0: Added 2 lines (use import)