fix(zero-c): fail closed for unsupported aarch64 ELF IR#253
Open
VelariumAI wants to merge 1 commit into
Open
Conversation
|
@VelariumAI is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #145.
This PR updates the AArch64 ELF backend so unsupported IR fails closed with a CGEN004 diagnostic instead of allowing successful emission of a misleading executable.
The change is intentionally limited to validation and diagnostic behavior. It does not add new AArch64 code generation support.
What changed
world.out.writelowering, Linux write syscall lowering, general call lowering, or broader backend support.Validation
make -C native/zero-c.bash bin/zero --versionsucceeds.zero new cli hellosucceeds.zero check .succeeds.zero test .succeeds.zero build .fails with CGEN004 for unsupported AArch64 ELF lowering.zero run .fails with the same diagnostic.native/zero-c/src/emit_elf_aarch64.c.Scope
This PR does not change:
Notes
This is the fail-closed compiler behavior fix. It does not make unsupported AArch64 programs run successfully. Follow-up work can add actual AArch64 lowering for specific constructs in separate PRs.