Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silent-cameras-embed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'ai': patch
---

fix(ai): default missing embedding warnings to an empty array
45 changes: 45 additions & 0 deletions packages/ai/src/embed/embed-many.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
vitest,
} from 'vitest';
import * as logWarningsModule from '../logger/log-warnings';
import { MockEmbeddingModelV2 } from '../test/mock-embedding-model-v2';
import { MockEmbeddingModelV4 } from '../test/mock-embedding-model-v4';
import type { Embedding, EmbeddingModelUsage, Warning } from '../types';
import { createResolvablePromise } from '../util/create-resolvable-promise';
Expand Down Expand Up @@ -423,6 +424,21 @@ describe('result.warnings', () => {
expect(result.warnings).toStrictEqual(expectedWarnings);
});

it('should default missing v2 provider warnings to an empty array in the single call path', async () => {
const result = await embedMany({
model: new MockEmbeddingModelV2<string>({
maxEmbeddingsPerCall: null,
doEmbed: async () => ({
embeddings: dummyEmbeddings,
usage: { tokens: 3 },
}),
}),
values: testValues,
});

expect(result.warnings).toStrictEqual([]);
});

it('should aggregate warnings from multiple calls', async () => {
const warning1: Warning = {
type: 'other',
Expand Down Expand Up @@ -460,6 +476,35 @@ describe('result.warnings', () => {

expect(result.warnings).toStrictEqual([warning1, warning2]);
});

it('should default missing v2 provider warnings to an empty array in the chunked path', async () => {
let callCount = 0;

const result = await embedMany({
model: new MockEmbeddingModelV2<string>({
maxEmbeddingsPerCall: 2,
doEmbed: async () => {
switch (callCount++) {
case 0:
return {
embeddings: dummyEmbeddings.slice(0, 2),
usage: { tokens: 2 },
};
case 1:
return {
embeddings: dummyEmbeddings.slice(2),
usage: { tokens: 1 },
};
default:
throw new Error('Unexpected call');
}
},
}),
values: testValues,
});

expect(result.warnings).toStrictEqual([]);
});
});

describe('logWarnings', () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/ai/src/embed/embed-many.ts
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export async function embedMany({
return {
embeddings,
usage,
warnings: modelResponse.warnings,
warnings: modelResponse.warnings ?? [],
providerMetadata: modelResponse.providerMetadata,
response: modelResponse.response,
};
Expand Down Expand Up @@ -317,7 +317,7 @@ export async function embedMany({
return {
embeddings: chunkEmbeddings,
usage,
warnings: modelResponse.warnings,
warnings: modelResponse.warnings ?? [],
providerMetadata: modelResponse.providerMetadata,
response: modelResponse.response,
};
Expand Down
15 changes: 15 additions & 0 deletions packages/ai/src/embed/embed.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { EmbeddingModelV4 } from '@ai-sdk/provider';
import assert from 'node:assert';
import { beforeEach, describe, expect, it, vi, vitest } from 'vitest';
import * as logWarningsModule from '../logger/log-warnings';
import { MockEmbeddingModelV2 } from '../test/mock-embedding-model-v2';
import { MockEmbeddingModelV4 } from '../test/mock-embedding-model-v4';
import type { Embedding, EmbeddingModelUsage, Warning } from '../types';
import { embed } from './embed';
Expand Down Expand Up @@ -181,6 +182,20 @@ describe('result.warnings', () => {

expect(result.warnings).toStrictEqual(expectedWarnings);
});

it('should default missing v2 provider warnings to an empty array', async () => {
const result = await embed({
model: new MockEmbeddingModelV2<string>({
doEmbed: async () => ({
embeddings: [dummyEmbedding],
usage: { tokens: 1 },
}),
}),
value: testValue,
});

expect(result.warnings).toStrictEqual([]);
});
});

describe('logWarnings', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/ai/src/embed/embed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export async function embed({
return {
embedding,
usage,
warnings: modelResponse.warnings,
warnings: modelResponse.warnings ?? [],
providerMetadata: modelResponse.providerMetadata,
response: modelResponse.response,
};
Expand Down
Loading