feat/fix(gchat) support Select and RadioSelect card actions#383
Open
mdnanocom wants to merge 1 commit intovercel:mainfrom
Open
feat/fix(gchat) support Select and RadioSelect card actions#383mdnanocom wants to merge 1 commit intovercel:mainfrom
mdnanocom wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
@mdnanocom is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a Google Chat adapter gap where
SelectandRadioSelectelements insideActionswere not converted into Google ChatselectionInputwidgets.The cross-platform card API exposes these primitives as supported interactive elements, but in
@chat-adapter/gchatthey were effectively dropped during card conversion, which could result in empty action sections for cards that used selection widgets instead of buttons.What changed
SelectinActionsto Google ChatselectionInputdropdown widgetsRadioSelectinActionsto Google ChatselectionInputradio widgetscommonEventObject.formInputsinhandleCardClick()whenparameters.valueis not presentActionsgroupWhy this shape
Google Chat surfaces selection widget values through form inputs rather than the same parameter path used by button clicks, so fixing rendering alone is not enough. This PR updates both sides of the adapter so selection widgets render and round-trip correctly through
onAction.Tests
Added adapter-level coverage for:
Select->selectionInputRadioSelect->selectionInputformInputsparameters.valueValidation
pnpm --filter @chat-adapter/gchat testpnpm --filter @chat-adapter/gchat typecheck