feat(eve): define HITL request ownership lifecycle - #1578
Open
ruiconti wants to merge 3 commits into
Open
Conversation
Signed-off-by: Rui Conti <ruiconti@gmail.com>
Signed-off-by: Rui Conti <ruiconti@gmail.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Rui Conti <ruiconti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ask_questionopts into supersession by its originating actor.input.requested; every non-settlement closure emitsinput.dismissedwith a stable reason (superseded,cancelled,session-ended,route-lost).Behavior
Before: an unrelated message lands in
deferredStepInputand the session waits again without a model call. Parent cancellation and fresh child batches also drop request routes without telling the channel.After: the message runs; the request stays pending out of band and is answerable late by splicing the stored approval suffix plus response — SDK-valid because
collectToolApprovalsonly requires the tail tool message. Requests raised by one model step form a suffix group that splices when its last member closes.Implementation surface
Two structural changes: pending requests become a per-
requestIdcollection (today a singleton batch), and requests bind their originating{ issuer, principalId }at creation. Acceptance gate: extendtool-loop-generate-approval-resume.integration.test.tswith an intervening turn before the approval response.Scope
Contract only; no runtime changes. PR #1368 owns responder authorization and settlement events. PR #1231 denies unanswered approvals on any follow-up; this proposal keeps them pending instead.