fix(eve): preserve authored tool and channel type precision - #1722
Draft
vercel-gh-bot-4[bot] wants to merge 1 commit into
Draft
fix(eve): preserve authored tool and channel type precision#1722vercel-gh-bot-4[bot] wants to merge 1 commit into
vercel-gh-bot-4[bot] wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1717.
defineTool(...)widened concrete executor returns to the full runtime union, and cross-channel selection rejected valid closed receive-target interfaces such as Slack's. Both failures appeared during TypeScript compilation even though runtime behavior already supported the authored definitions.The hypothesis is that preserving the executor function in overload inference, while keeping
ToolDefinition<TInput, TOutput>broad, restores precise authored returns without breaking explicit generic consumers. Constraining cross-channel selection withChannelReference<unknown>lets TypeScript infer the channel's exact receive target.This change adds compile-time coverage for async, async-generator, mixed streaming, projection-order, explicit-generic, and Slack target cases. It also retains tool extension epoch 7 while recording epoch 8.
Validation:
pnpm --filter eve typecheckpnpm guard:invariantsoxfmtandoxlintrun-vercelassertions detect the sandbox's/tmp/node_modules/.bin/vercelinstead of the expected missing local binary.