Skip to content

fix(eve): avoid dev snapshot watcher subscriptions - #609

Open
iroiro147 wants to merge 3 commits into
vercel:mainfrom
iroiro147:fix/dev-runtime-snapshot-watchers-570
Open

fix(eve): avoid dev snapshot watcher subscriptions#609
iroiro147 wants to merge 3 commits into
vercel:mainfrom
iroiro147:fix/dev-runtime-snapshot-watchers-570

Conversation

@iroiro147

Copy link
Copy Markdown
Contributor

Summary

  • prevent Rolldown's dev watcher from subscribing to authored app source roots during eve dev
  • disable Nitro config watching in dev because Eve's authored-source watcher owns rebuild/reload
  • add scenario coverage for both dev watcher settings

Refs #570.

Tests

  • pnpm --filter eve exec vitest run --config vitest.scenario.config.ts src/internal/nitro/host/create-application-nitro.scenario.test.ts
  • pnpm --filter eve exec vitest run --config vitest.scenario.config.ts src/internal/nitro/host/dev-authored-source-watcher.scenario.test.ts src/internal/nitro/host/create-application-nitro.scenario.test.ts
  • pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/internal/nitro/host/start-development-server.test.ts
  • pnpm exec oxfmt --check packages/eve/src/internal/nitro/host/create-application-nitro.ts packages/eve/src/internal/nitro/host/create-application-nitro.scenario.test.ts .changeset/dev-runtime-nitro-watchers.md
  • pnpm exec oxlint packages/eve/src/internal/nitro/host/create-application-nitro.ts packages/eve/src/internal/nitro/host/create-application-nitro.scenario.test.ts
  • git diff --check
  • pnpm --filter eve run typecheck
  • pnpm guard:invariants
  • pnpm changeset status --since origin/main

@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@iroiro147 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@iroiro147
iroiro147 force-pushed the fix/dev-runtime-snapshot-watchers-570 branch from 493fab8 to 5432ca2 Compare July 12, 2026 11:40
@iroiro147

Copy link
Copy Markdown
Contributor Author

Rebased onto current main while preserving the newer mounted-extension and named-agent Nitro configuration. The patch still excludes app-root subscriptions from Rolldown and disables Nitro’s duplicate config watcher.\n\nValidated the full Nitro scenario file (18 tests), the eve package typecheck, invariant guard, and changed-file formatting.

Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
@iroiro147
iroiro147 force-pushed the fix/dev-runtime-snapshot-watchers-570 branch from 5432ca2 to 74216c6 Compare July 30, 2026 06:23
@iroiro147

Copy link
Copy Markdown
Contributor Author

Rebased onto latest main (74216c6). Resolved conflicts in create-application-nitro.ts and create-application-nitro.scenario.test.ts — took PR version, which replaces main's file-watcher subscription approach with polling-based snapshot refresh to avoid dev-mode watcher subscription overhead.

…tyTransformPlugin

Signed-off-by: iroiro147 <sarthak.singh@mastersunion.org>
…ounts)

Signed-off-by: iroiro147 <sarthak.singh@mastersunion.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant