Skip to content

fix(eve): route preview workflows to latest deployment - #616

Open
iroiro147 wants to merge 4 commits into
vercel:mainfrom
iroiro147:fix/preview-latest-deployment-582
Open

fix(eve): route preview workflows to latest deployment#616
iroiro147 wants to merge 4 commits into
vercel:mainfrom
iroiro147:fix/preview-latest-deployment-582

Conversation

@iroiro147

Copy link
Copy Markdown
Contributor

Summary

  • try deploymentId: "latest" before pinned workflow starts so Git-connected preview deployments can pick up newer branch deployments
  • fall back to the current deployment when the active workflow world cannot resolve latest, including branchless deployments that return Source deployment has no git branch
  • cover runtime and turn dispatch behavior, and document the Git-connected latest routing/fallback behavior

Fixes #582.

Tests

  • pnpm --filter eve run build:compiled
  • pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/execution/workflow-runtime.test.ts src/execution/workflow-steps.test.ts (36 passed)
  • pnpm --filter eve run typecheck
  • pnpm docs:check
  • pnpm guard:invariants
  • pnpm --filter eve exec oxlint src/execution/workflow-runtime.ts src/execution/workflow-runtime.test.ts src/execution/workflow-steps.test.ts --deny-warnings
  • pnpm exec oxfmt --check packages/eve/src/execution/workflow-runtime.ts packages/eve/src/execution/workflow-runtime.test.ts packages/eve/src/execution/workflow-steps.test.ts docs/concepts/execution-model-and-durability.md docs/guides/deployment.md .changeset/preview-latest-routing.md
  • pnpm changeset status --since origin/main
  • git diff --cached --check

All checks above ran under Node 24.14.0.

@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@iroiro147 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@iroiro147
iroiro147 force-pushed the fix/preview-latest-deployment-582 branch from 64a8f01 to f72939d Compare July 12, 2026 12:14
@iroiro147

Copy link
Copy Markdown
Contributor Author

Rebased this onto current main and pushed signed head f72939da. Verified under Node 24 with 36 focused workflow tests, package typecheck, documentation checks, invariant checks, and git diff --check. The core CI suite is green on the rebased head; the remaining TUI/E2E and preview failures require repository credentials.

Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
@iroiro147
iroiro147 force-pushed the fix/preview-latest-deployment-582 branch from f72939d to 4422c39 Compare July 30, 2026 06:20
@iroiro147

Copy link
Copy Markdown
Contributor Author

Rebased onto latest main (4422c39). Resolved 4 file conflicts:

  • docs/guides/deployment.md: main deleted this file; respected the deletion.
  • workflow-runtime.ts: took PR version — main added shouldRouteToLatestDeployment while the PR adds clearLatestDeploymentFallbackMemoForTest and a different latest-routing approach.
  • workflow-steps.test.ts: took PR version to match the implementation's preview-deployment routing tests.
  • workflow-runtime.test.ts: merged — kept main's getHookByTokenMock.mockReset() + PR's clearLatestDeploymentFallbackMemoForTest() in afterEach.

iroiro147 and others added 3 commits July 31, 2026 18:36
Resolve conflicts by preserving the PR's preview-deployment routing
feature while reconciling with main:
- workflow-runtime.ts: take PR version (startWorkflowPreferLatest /
  clearLatestDeploymentFallbackMemoForTest), dropping the cancel-block
  the PR intentionally removed in its own rebase of 4422c39.
- workflow-steps.test.ts: union imports (PR keep of
  DEFAULT_SUBAGENT_MAX_DEPTH + main's getPendingRuntimeActionBatch /
  requestTurnSleep).
…ployment-582

Signed-off-by: iroiro147 <sarthak.singh@mastersunion.org>
…#616 semantics

Signed-off-by: iroiro147 <sarthak.singh@mastersunion.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turn dispatch never routes parked sessions to new deployments on preview (VERCEL_ENV gate is stricter than the platform)

1 participant