-
Notifications
You must be signed in to change notification settings - Fork 59
Add retries to flag network datasource #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated dependencies to fix Next.js and React CVE vulnerabilities. The fix-react2shell-next tool automatically updated the following packages to their secure versions: - next - react-server-dom-webpack - react-server-dom-parcel - react-server-dom-turbopack All package.json files have been scanned and vulnerable versions have been patched to the correct fixed versions based on the official React advisory. Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
# Conflicts: # pnpm-lock.yaml
Implements automatic retry logic with exponential backoff when the flag network stream unexpectedly closes. The stream will retry with delays increasing from 1s to a maximum of 30s, allowing the datasource to recover from temporary network issues while falling back to bundled definitions if initial connection fails. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dferber90
reviewed
Jan 20, 2026
| private hasReceivedData: boolean = false; | ||
| private retryCount: number = 0; | ||
| private readonly maxRetryDelay: number = 30000; // 30 seconds max delay | ||
| private readonly baseRetryDelay: number = 1000; // 1 second initial delay |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we retry once immediately?
dferber90
reviewed
Jan 20, 2026
| let eventData: string | null = null; | ||
| while (!this.breakLoop) { | ||
| try { | ||
| console.log(process.pid, 'createLoop → MAKE STREAM'); |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover?
dferber90
pushed a commit
that referenced
this pull request
Jan 24, 2026
* Fix React Server Components CVE vulnerabilities (#235) Updated dependencies to fix Next.js and React CVE vulnerabilities. The fix-react2shell-next tool automatically updated the following packages to their secure versions: - next - react-server-dom-webpack - react-server-dom-parcel - react-server-dom-turbopack All package.json files have been scanned and vulnerable versions have been patched to the correct fixed versions based on the official React advisory. Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> * Add retries to flag network datasource when stream closes Implements automatic retry logic with exponential backoff when the flag network stream unexpectedly closes. The stream will retry with delays increasing from 1s to a maximum of 30s, allowing the datasource to recover from temporary network issues while falling back to bundled definitions if initial connection fails. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * Revert package.json and pnpm-lock changes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com> Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements automatic retry logic with exponential backoff when the flag network stream unexpectedly closes. The stream will retry with delays increasing from 1s to a maximum of 30s, allowing the datasource to recover from temporary network issues while falling back to bundled definitions if initial connection fails.
Changes:
shutdown()method to cleanly stop the retry loopBehavior: