Fix no-html-link-for-pages rule to respect custom pageExtensions - #96953
Open
ecryptoguru wants to merge 1 commit into
Open
Fix no-html-link-for-pages rule to respect custom pageExtensions#96953ecryptoguru wants to merge 1 commit into
ecryptoguru wants to merge 1 commit into
Conversation
The `no-html-link-for-pages` ESLint rule was not accounting for custom `pageExtensions` configured in `next.config.js`. When users configured non-default extensions (e.g. `.page.tsx`), the rule would either miss valid pages or incorrectly flag links as violations. This change: - Reads `pageExtensions` from ESLint settings and passes it through to the page/app directory resolution logic in `url.ts` - Updates `isTargetPage` and related helpers to match files using the configured extensions instead of hardcoding `.tsx`/`.ts`/etc. - Adds test fixtures and test cases covering custom `pageExtensions` for both `pages/` and `app/` directories Closes vercel#53473 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #53473
The
no-html-link-for-pagesESLint rule was not accounting for custompageExtensionsconfigured innext.config.js. When users configured non-default extensions (e.g..page.tsx), the rule would either miss valid pages or incorrectly flag links as violations.