fix(next-playwright): scope instant cookie cleanup to app URL - #96962
Open
teamleaderleo wants to merge 1 commit into
Open
fix(next-playwright): scope instant cookie cleanup to app URL#96962teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96961
What
instant()sets its testing cookie for one application hostname, but cleanup currently searches the entire PlaywrightBrowserContextfor cookies with the same name.This changes cleanup from:
to:
so it only expires testing cookies that apply to the application URL being controlled.
Why
If the browser context also contains a
next-instant-navigation-testingcookie for another origin, callinginstant()for app A can currently delete app B’s cookie.Using Playwright’s URL-filtered cookie lookup keeps the existing cookie domain/path behavior while avoiding cleanup of cookies that don’t apply to app A.
Tests
Added coverage to the existing Instant Navigation testing suite verifying that another origin’s testing cookie survives both entering and leaving an
instant()scope.