feat(vercel-sandbox): fix bug with resuming sandbox during file read#102
Merged
marc-vercel merged 2 commits intonamed-sandboxesfrom Mar 18, 2026
Merged
feat(vercel-sandbox): fix bug with resuming sandbox during file read#102marc-vercel merged 2 commits intonamed-sandboxesfrom
marc-vercel merged 2 commits intonamed-sandboxesfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AndyW22
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug with resuming sandboxes when reading a file. I have also added an integration tests to detect if this behavior is broken in the future, as it follows a different path from the other commands (it is a stream).
TL;DR: we were missing the
parseOrThrowin this method, andwithResume()wrapper checks for an error before resuming (we were returning the error as string)