Fix bug when extract multiple adjacent words from a string without word boundaries#142
Open
lishukan wants to merge 50 commits intovi3k6i5:masterfrom
Open
Fix bug when extract multiple adjacent words from a string without word boundaries#142lishukan wants to merge 50 commits intovi3k6i5:masterfrom
lishukan wants to merge 50 commits intovi3k6i5:masterfrom
Conversation
added reference to flashtext paper
added citation
corrected citation
`charactes` | `characters` `explaination` | `explanation` `matche` | `match`
Fix issue with incomplete keyword at the end of the sentence
Performances improvement for strings manipulations
…with extract_keywords
…kes in testing doc
Fuzzy matching
…g idx should be rolled back one bit.
|
邮件已收到。
|
Author
|
@vi3k6i5 Hello, dear owner . Is this repo still maintained ？ I found that this repo hasn't updated its code for a long time . If it is no longer maintained, I will no longer wait for the merge of the MR. |
支持中英文夹杂的情况
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear developers：
There is no doubt that flashtext is an excellent string matching tool. I have already used it on a large number of occasions. But recently I found it in a string without word boundaries (such as a Chinese sentence),
If two words that need to be extracted happen to be adjacent, then it will only be able to extract the first word.
So I made some modifications: when matching words, the index for the next iteration will start at the end of the last matched word.
I have added a new use case and It passed all unit tests.