span_info on combined unicode characters#82
Open
kkaiser wants to merge 49 commits intovi3k6i5:masterfrom
Open
Conversation
added reference to flashtext paper
added citation
corrected citation
`charactes` | `characters` `explaination` | `explanation` `matche` | `match`
Fix issue with incomplete keyword at the end of the sentence
Performances improvement for strings manipulations
…a per char basis to return correct span_info
…kes in testing doc
turkay
approved these changes
Oct 11, 2019
Open
0x01h
approved these changes
Apr 15, 2020
Owner
|
Moving the check inside the loop ads a little of execution overhead, please share a test case for the change. Thanks |
Fuzzy matching
Owner
|
Can you please resolve the conflict. |
Author
|
Ready for review |
|
This is still happening with flashtext-2.7 |
|
@vi3k6i5 - Hi there! Is this ready for and can you complete merging this PR? |
HCYT
added a commit
to termdock/flashtext-i18n
that referenced
this pull request
Jan 13, 2026
Problem: - Turkish İ lowercases to 'i̇' (2 chars), changing string length - Lowercasing entire sentence upfront caused span position offsets Solution: - Lowercase each character individually during traversal - This preserves original string indices for span_info Fixes: #2 Ref: upstream vi3k6i5/flashtext#119, vi3k6i5/flashtext#81, vi3k6i5/flashtext#82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue: #81
Lowering a sentence with combined unicode chars changes the length of a sentence.
Lowering keywords and search sentence now works on a per char basis to return the correct span_info