Fix #13 by inlining base 64 image for secret user#16
Open
RomainSauvaire wants to merge 2 commits intoviacreative:masterfrom
RomainSauvaire:remove-font-awesome-external-dependency
Open
Fix #13 by inlining base 64 image for secret user#16RomainSauvaire wants to merge 2 commits intoviacreative:masterfrom RomainSauvaire:remove-font-awesome-external-dependency
RomainSauvaire wants to merge 2 commits intoviacreative:masterfrom
RomainSauvaire:remove-font-awesome-external-dependency
Conversation
So the whole fa-* doesn't have to be downloaded. This is retina ready, the generated base64 is 24px wide and the `width` attribute is only 12px
krve
reviewed
Apr 5, 2017
| <div class="sudoSu"> | ||
| <div class="sudoSu__btn {{ $hasSudoed ? 'sudoSu__btn--hasSudoed' : '' }}" id="sudosu-js-btn"> | ||
| <i class="fa fa-user-secret" aria-hidden="true"></i> | ||
| <img width="12" height="14" alt="User secret icon" aria-hidden="true" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABgAAAAYCAMAAADXqc3KAAABF1BMVEUAAAD////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////jvJXZAAAAXHRSTlMAAQIDBAYHCAsMDRAUFRcaHB4gIiMkKCkqKy0wNDo8PT4/QUVGSUxQUVRZYmxvcHF3eHt8foKGiIyOj5eYm6Clpqqrrbm6vsDFx8jMzs/V2dze5Obr7e/x9ff7/V2zNpYAAAD5SURBVBgZZcELI8JQGAbgdxsp5prILeS+QhIhJHItISqr9///DjvfdrR4Hmhm3ARik/jnlq1siVzDH0v0dSwMemJgA2FGktpzDH37LkMaSQSMK4Z9p/ErctwunlZab5cn11w0ELLSNAADwAwt9Nl2mgtAfgootW17FNoLyc+dQ77v5ujZg5bigCi0IYY9QjPvSB7U6DmvkNxG4IieVRTJOdzTE4eIUsnDrGdg9Oh5gNikUgPOEhijGIFyQWGi6WCZYhZKnWIiwhtkKbagdCjWE3RRpXCguBQFhxzvUWSgVCley2SBvhSUefq6ZJfiw4KYLn8xpJEbBvAD4nJnwFNQ0yUAAAAASUVORK5CYII=" |
Contributor
There was a problem hiding this comment.
The <img> tag is not ending? The last character is "
Author
There was a problem hiding this comment.
My bad, I feel stupid. Will fix that.
Author
|
Should be good. Apologize again |
Contributor
|
@RomainSauvaire no need to apologize, typos happen 😄 |
Collaborator
|
Just to let you know, I've still got this on my to-do list! Super hectic at work. I'll look ASAP, I promise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the whole fa-* doesn't have to be downloaded.
This is retina ready, the generated base64 is 24px wide and the
widthattribute is only 12px