Skip to content

Revert "RSDK-13440 Add support for tflite OWW models"#20

Merged
oliviamiller merged 5 commits into
mainfrom
revert-18-tflite
Mar 23, 2026
Merged

Revert "RSDK-13440 Add support for tflite OWW models"#20
oliviamiller merged 5 commits into
mainfrom
revert-18-tflite

Conversation

@oliviamiller
Copy link
Copy Markdown
Collaborator

@oliviamiller oliviamiller commented Mar 23, 2026

the build on filtered-audio is failing due to dependency conflicts between onnx and tflite on glibc2.31, which weren't caught on the PR check due to a CI bug causing the build check to run on the last commit on main rather than the PR commit. Couldn't find an easy fix so i'm reverting the tflite support PR and will revisit later.

Reverts #18

@oliviamiller oliviamiller marked this pull request as ready for review March 23, 2026 16:46
@hexbabe
Copy link
Copy Markdown

hexbabe commented Mar 23, 2026

can you add

the build on filtered-audio is failing due to dependency conflicts between onnx and tflite on glibc2.31, which weren't caught on the PR check due to a CI bug. Couldn't find an easy fix so i'm reverting the tflite support PR and will revisit later.

to the pr desc

@hexbabe
Copy link
Copy Markdown

hexbabe commented Mar 23, 2026

how did you spin up this PR did you use git commands?

@oliviamiller
Copy link
Copy Markdown
Collaborator Author

how did you spin up this PR did you use git commands?

I clicked the revert button on the merged PR.

Copy link
Copy Markdown

@SebastianMunozP SebastianMunozP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebastianMunozP
Copy link
Copy Markdown

Can you include here what the issue with CI was?, just for future reference.

@oliviamiller
Copy link
Copy Markdown
Collaborator Author

Can you include here what the issue with CI was?, just for future reference.

added more detail on description.

@oliviamiller oliviamiller merged commit 699b053 into main Mar 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants