Stream OWW in real time#22
Open
oliviamiller wants to merge 1 commit into
Open
Conversation
seanavery
reviewed
May 28, 2026
| ): | ||
| yield chunk | ||
| if oww_streaming: | ||
| # Already streamed — just emit segment-end sentinel |
There was a problem hiding this comment.
Do we need to yield the last chunk here before inserting the empty marker?
Just making sure we are not dropping data here. Maybe chunks counter check in the tests to verify?
|
|
||
| # OWW just fired this frame — flush buffered chunks and switch to streaming. | ||
| # Gate on state to ignore OWW false-positives during silence between segments. | ||
| if ( |
There was a problem hiding this comment.
Could OWW fire while state=IDLE? If so, the next frame's was_detected is already True and streaming never starts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from the buffer and subsequent chunks yield live instead of waiting for segment end. Vosk
path unchanged (still batch).
state != IDLEso OWW false-positives duringbetween-segment silence don't start a phantom stream.
Testing
sentinel, mid-stream pause, mid-stream mic-end, and Vosk regression
Approvals
1 approval needed.