Add cgo accessible logging shim for the custom ffmpeg log callback#93
Merged
Conversation
Contributor
|
Sweet! Thanks for doing this. Looks like it already has reviewer coverage, so I'm going to bow out |
seanavery
commented
May 26, 2026
| vsutils.SetFFmpegLogCallback() | ||
| vsutils.SetFFmpegLogCallback(logger) | ||
|
|
||
| module, err := module.NewModuleFromArgs(ctx) |
Collaborator
Author
There was a problem hiding this comment.
@cheukt I had to move to NewModule to get the logger working. NewModuleFromArgs logger return seemed to be behaving differently, is that expected?
There was a problem hiding this comment.
ya NewModuleFromArgs creates a blank logger for you, so having to thread it through makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We currently have coarse FFmpeg log handling: the cgo callback formats each line and dumps it to stderr/stdout via fprintf, and we rely on the viam-server parent process to interpret stderr as errors and stdout as info.
This PR changes the callback to hand the formatted line and level up to a Go shim, which routes it through the module's logging.Logger under an ffmpeg sublogger (libav levels map onto rdk loglevels).
Testing