APP-16486 - viam server running version in app's agent_subsystem_versions should be accurate

[cheukt]

technically the ViamServerRunningVersion is a reflection of the desired running version (since it will be populated even if the viam-server has not successfully started up), but this change is better than what it is now.

maybe we should push the viam-server state too (running, initializing, etc)

[benjirewis]

LGTM.

More broadly though: what's the point of viam-agent and viam-server both submitting a viam-server version? Is another possible solution to stop reporting viam-server versions from viam-agent? Especially if the values aren't used anywhere in the frontend and the viam-server versions reported by agent aren't as accurate as the one reported by viam-server itself.

[benjirewis]

maybe we should push the viam-server state too (running, initializing, etc)

Similar question there for me: why can't we just rely on the frontend querying viam-server directly for its status?

[cheukt]

More broadly though: what's the point of viam-agent and viam-server both submitting a viam-server version? Is another possible solution to stop reporting viam-server versions from viam-agent? Especially if the values aren't used anywhere in the frontend and the viam-server versions reported by agent aren't as accurate as the one reported by viam-server itself.

good point, i think from my perspective the view from agent is useful, and especially if agent is trying to run viam-server at a specific version but failing to (the viam_server version field in that map tracks the desired version, while viam_server_running tracks the version attempted at running).

Similar question there for me: why can't we just rely on the frontend querying viam-server directly for its status?

there's the case that viam-server is just not coming up at all where having some diagnostic from agent may be useful