Conversation
Dev release artifactsBuilt from
Remove the |
| } | ||
| } | ||
| if !m.viamServerNeedsRestart { | ||
| m.cache.MarkViamServerRunningVersion() |
There was a problem hiding this comment.
[q] How is this different from what we initially had (I mean a week ago before your last PR/commit)? I'm having trouble parsing the if m.viamServerNeedsRestart || m.viamAgentNeedsRestart followed by if !m.viamServerNeedsRestart {. With which case are we not marking a running viam-server version with your changes that we were previously marking?
There was a problem hiding this comment.
what we initially had was that we were always marking a running a viam-server version, which is bad if the viam-server didn't actually get stopped/get restarted.
now, if stopping viam-server failed, m.viamServerNeedsRestart will stay true and we won't be marking the running viam-server version.
that's the intended change anyway
There was a problem hiding this comment.
if stopping viam-server failed, m.viamServerNeedsRestart will stay true and we won't be marking the running viam-server version.
Got it; that makes sense to me. Thanks!
2 participants
I couldn't make a dev release for my last pr because I pushed to my fork instead of this, so this pr fixes an issue that I found very quickly after testing
the running version wouldn't be marked until the first time viam-server stopped