Skip to content

Sign Windows msi#246

Merged
cheukt merged 3 commits into
mainfrom
sign-msi
May 29, 2026
Merged

Sign Windows msi#246
cheukt merged 3 commits into
mainfrom
sign-msi

Conversation

@cheukt
Copy link
Copy Markdown
Member

@cheukt cheukt commented May 28, 2026

might as well sign the msi too.

manual testing - still get windows defender warnings but apparently we just have to build up reputation. checked the msi and binary through osslsigncode and they're all signed properly.

@cheukt cheukt added the dev-release Build and publish agent binaries with a dev version label May 28, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

@cheukt cheukt requested a review from aldenh-viam May 29, 2026 20:00
@cheukt cheukt merged commit 011b369 into main May 29, 2026
6 checks passed
@cheukt cheukt deleted the sign-msi branch May 29, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-release Build and publish agent binaries with a dev version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants