[RSDK-14024] When cgo is present use trajex for the simulated arm#6042
Draft
acmorrow wants to merge 1 commit into
Draft
[RSDK-14024] When cgo is present use trajex for the simulated arm#6042acmorrow wants to merge 1 commit into
acmorrow wants to merge 1 commit into
Conversation
Member
Author
|
@dgottlieb - Forgot to mention that if you want a smaller faster build for trajex, you can add |
dgottlieb
reviewed
May 27, 2026
Member
dgottlieb
left a comment
There was a problem hiding this comment.
Has all the right stuff. High level preference is to align with the upcoming arm API proposal and ideally instrument simarm with trajex for convenient comparison, but also let be able to control it without going through trajex. And not needing to wait for a config change observe that comparison. More detail on a random line of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dgottlieb - Opening this as a draft, for discussion and for you to be able to do local testing, not proposing that we merge it just yet.
This change demonstrates using trajex in the simulated arm by way of the trajex go bindings (viam-modules/trajex#15) and C api (viam-modules/trajex#14).
To build against this, you will need to:
cmake -B build -S . -G Ninja) and build (e.g.cmake --build build --target all) the trajex libraries. Note that you must call the build directorybuild, and it must be at the root of thetrajextree.go mod edit -replace github.com/viam-modules/trajex=../trajex(update the replacement path as needed).You should now be able to build and test the simulated arm using trajex:
go test -count=1 ./components/arm/sim/...If everything worked right, it should compile and link and you should be using the new trajectory generator.
Note that I'm still testing this, but I wanted to let you have an early look in case you had any feedback on the shape of things. I'll let you know once I'm happy with it, and then you should be able to experiment with invoking it from motion.
If we decide this is the right direction, then we can start figuring out what our production build and release story ought to look like.