[RSDK-13658] Expose force_relay/force_p2p/turn_uri DialOptions#1208
Merged
Conversation
Add the matching Python kwargs for the rust-utils FFI flags landed in viamrobotics/rust-utils#176 so SDK callers can drive ICE relay/P2P testing and TURN-server filtering without reaching into the C ABI. Switches `_Runtime` to the `viam_*`-prefixed FFI symbols (viam_init_rust_runtime / viam_dial / viam_free_string / viam_free_rust_runtime). The previously called functions were already `#[deprecated]` upstream; this just stops asking for the deprecation warning and lets us pass the new args. Mirrors rust-utils' two pre-flight conflict warnings (force_relay + force_p2p, force_p2p + turn_uri) on the Python side so callers see them before the FFI hop. Compatibility: requires a rust-utils release that ships PR #176. Once that release is out, `etc/postinstall.sh` will pull a dylib whose viam_dial accepts the new 10-arg signature; older dylibs do not, and calling this code against them is undefined behavior. **Do not merge this PR until that rust-utils release is cut.** Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stuqdog
approved these changes
May 5, 2026
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
lgtm! note though that this shouldn't be merged until the corresponding rust-utils feature is.
6 tasks
|
Hey @danielbotros — this PR has been approved and CI has been green for 3+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey @danielbotros — this PR has been approved and CI has been green for 3+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
force_relay,force_p2p,turn_urikwargs toDialOptionsso callers can drive ICE relay/P2P testing and TURN-server filtering. The user-facing API is unchanged from prior iterations of this branch — the FFI wiring underneath is what changed._Runtimeto the new opaque-opts FFI introduced in [RSDK-13658] Plumb force_relay/force_p2p/turn_uri through C FFI rust-utils#176:viam_dial_with_opts+viam_dial_opts_new/_free/ 3 setters, instead of a 10-argviam_dial, with explicit alloc/free memory management around the opts handle inLibraryHandle.dial.Won't merge until
libviam_rust_utils.*artifacts are updated.Test plan
LibraryHandle()resolves every new symbol (viam_dial_opts_new/_free/_set_force_relay/_set_force_p2p/_set_turn_uri,viam_dial_with_opts)ruff check,ruff format,pyrightall clean onsrc/viam/rpc/dial.pyforce_relaypins ICE to relay candidates against coturn;force_p2ppins to host/srflx/prflx only;turn_urifilters the TURN list