fix: hide transform controls on invisible entities (#718)#719
Merged
Conversation
Check InheritedInvisible trait on the selected entity before rendering TransformControls, so hidden entities don't show the transform gizmo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: b950c94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
micheal-parks
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://viam.atlassian.net/browse/APP-16641
TransformControlswhen the selected entity has theInheritedInvisibletrait, preventing the transform gizmo from appearing on hidden entitiesInheritedInvisible(not justInvisible) so controls are also hidden when a parent entity is invisible, matching the pattern used by all rendering components (Frame,Geometry,Points, etc.)Closes #718
DRI
@mattmacf98 is the responsible engineer for this PR.
Test plan
🤖 Generated with Claude Code
demo-transforms-hidden-when.invisible.mov