Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the self-referential checkmate input dependency from the flake configuration, eliminating a recursive dependency pattern where the checkmate project was referencing itself as an input.
Key Changes:
- Removed the checkmate input declaration from flake.nix
- Deleted the modules/checkmate/checkmate.nix configuration file
- Cleaned up the nested checkmate entries (checkmate, checkmate_2, checkmate_3) from flake.lock
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/checkmate/checkmate.nix | Entire file deleted - removed the checkmate input configuration with its dependency follows |
| flake.nix | Removed the checkmate input and its extensive input follows declarations |
| flake.lock | Removed three nested checkmate lock entries (checkmate, checkmate_2, checkmate_3) and the checkmate reference from root inputs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| nixpkgs.follows = "nixpkgs"; | ||
| nixpkgs-lib.follows = "nixpkgs"; | ||
| systems.follows = "systems"; | ||
| target.follows = "target"; |
There was a problem hiding this comment.
The configuration target.follows = "target" creates a circular reference. The checkmate input is being told to follow the parent's target input, but target itself points to a checkmate repository (github:vic/checkmate?dir=templates/success as defined in modules/checkmate/target.nix). This circular dependency appears to be the root cause of the nested checkmate references (checkmate_2, checkmate_3, checkmate_4) visible in the template's flake.lock.
Consider removing the target.follows = "target" line to break this circular dependency, or restructure the relationship between checkmate and target.
| target.follows = "target"; |
1 participant
No description provided.