Expose flake-file.apps as flake apps, not packages#92
Merged
Conversation
flake-file.apps as flake apps, not packagesflake-file.apps as flake apps, not packages
Owner
|
Hey @Adda0, I had no particular reason using packages instead of apps, other than I've never used apps. haha. If I'm understanding correctly, packages is for things that can be consumed downstream (by your flake consumers). Your change makes sense in that regard, feel free to also send a patch for Den |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was cleaning up my flake outputs and noticed that
write-flake,write-lock,write-inputs, and others are exposed as flake outputspackagesinstead of flake outputsapps.Since
packagesare supposed to be build artefacts and/or something installable, and these are, unless I misunderstood the intention, all just quick and small scripts only useful for the current configuration directory and are not expected to be installed and available onPATHfor general use in other directories, I think having them asapps would be more appropriate.Now:
The change is applied only when setting the
perSystemflake outputs, so hopefully it should not break anything in flake-ile, as all references use the unmodifiedflake-file.apps.Feel free to close the PR if exposing the scripts as
packageswas intentional or something.I think the same can be done to https://github.com/vic/den/blob/b7f910ab47260c91a0ae8d55fa72cd2178ba2458/templates/default/modules/nh.nix#L7.