Skip to content

fix Widgetbinding.instance null check issue #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SujeetKr6 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Widgetbinding.instance null check issue #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/ballon_transition.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class __OpacityAnimationWrapperState extends State<_OpacityAnimationWrapper> {
@override
void initState() {
super.initState();
WidgetsBinding.instance.addPostFrameCallback((timeStamp) {
WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
if (mounted) {
setState(() {
_opacity = 1;
Expand Down
2 changes: 1 addition & 1 deletion lib/src/balloon.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class __BallonState extends State<_Ballon> {

@override
Widget build(BuildContext context) {
WidgetsBinding.instance.addPostFrameCallback((timeStamp) {
WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
if (!mounted) return;
final RenderBox? renderBox = _containerKey.currentContext!.findRenderObject() as RenderBox?;
if (renderBox == null) return null;
Expand Down
2 changes: 1 addition & 1 deletion lib/src/balloon_positioner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class __BallonPositionerState extends State<_BallonPositioner> {
),
);

WidgetsBinding.instance.addPostFrameCallback((_) {
WidgetsBinding.instance?.addPostFrameCallback((_) {
final ballonContext = _ballonKey.currentContext;
if (ballonContext != null) {
// final bRenderO = ballonContext.findRenderObject();
Expand Down
6 changes: 3 additions & 3 deletions lib/src/obfuscate_tooltip_item.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class ObfuscateTooltipItemState extends State<ObfuscateTooltipItem> with Widgets
@override
void initState() {
super.initState();
WidgetsBinding.instance.addObserver(this);
WidgetsBinding.instance?.addObserver(this);
_intervalSubscription = Stream.periodic(Duration(seconds: 1)).listen((event) {
final currentPositionSize = getPositionAndSize();
if (_lastPositionSize != currentPositionSize) {
Expand All @@ -40,7 +40,7 @@ class ObfuscateTooltipItemState extends State<ObfuscateTooltipItem> with Widgets
}
_lastPositionSize = currentPositionSize;
});
WidgetsBinding.instance.addPostFrameCallback((timeStamp) {
WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
_addToTooltips(widget.tooltipKeys);
});
}
Expand All @@ -56,7 +56,7 @@ class ObfuscateTooltipItemState extends State<ObfuscateTooltipItem> with Widgets

@override
void dispose() {
WidgetsBinding.instance.removeObserver(this);
WidgetsBinding.instance?.removeObserver(this);
_intervalSubscription.cancel();
_removeFromTooltips(widget.tooltipKeys);
super.dispose();
Expand Down
10 changes: 5 additions & 5 deletions lib/src/tooltip.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,15 @@ class SimpleTooltipState extends State<SimpleTooltip> with RouteAware {

addObfuscateItem(ObfuscateTooltipItemState item) {
_obfuscateItems.add(item);
WidgetsBinding.instance.addPostFrameCallback((timeStamp) {
WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
doCheckForObfuscation();
doShowOrHide();
});
}

removeObfuscatedItem(ObfuscateTooltipItemState item) {
_obfuscateItems.remove(item);
WidgetsBinding.instance.addPostFrameCallback((timeStamp) {
WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
doCheckForObfuscation();
doShowOrHide();
});
Expand All @@ -185,7 +185,7 @@ class SimpleTooltipState extends State<SimpleTooltip> with RouteAware {
@override
void initState() {
super.initState();
WidgetsBinding.instance.addPostFrameCallback((_) {
WidgetsBinding.instance?.addPostFrameCallback((_) {
if (shouldShowTooltip) {
_showTooltip();
}
Expand All @@ -199,7 +199,7 @@ class SimpleTooltipState extends State<SimpleTooltip> with RouteAware {
oldWidget.routeObserver?.unsubscribe(this);
widget.routeObserver?.subscribe(this, ModalRoute.of(context) as PageRoute<dynamic>);
}
WidgetsBinding.instance.addPostFrameCallback((_) {
WidgetsBinding.instance?.addPostFrameCallback((_) {
if (oldWidget.tooltipDirection != widget.tooltipDirection || (oldWidget.show != widget.show && widget.show)) {
_transitionKey = GlobalKey();
}
Expand Down Expand Up @@ -358,7 +358,7 @@ class SimpleTooltipState extends State<SimpleTooltip> with RouteAware {
// Route was pushed onto navigator and is now topmost route.
if (shouldShowTooltip) {
_removeTooltip();
WidgetsBinding.instance.addPostFrameCallback((timeStamp) {
WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
if (!mounted) return;
_showTooltip();
});
Expand Down