Pss refact 2020 11 lucian palaghe

[lucianpalaghe]

Rezolvarea mea la exercitiul lasat ca tema 🤓

[victorrentea]

Foarte frumos. Cateva intrebari insa: [image: image.png] Astea de ce au ramas? 2: in jocul original trebuia sa dai impar pentru a putea apoi, DACA raspunzi corect, sa iesi din penalty box. Functionalitatea asta n-o mai regasesc in codul refactorat. 3. Frumoase nume de metode. 4. Ai gasit si bugul cu game over, super! 5. punish e un cuvant cam tare. E foarte bine! Multumesc ! *Victor Rentea* Independent Trainer & Consultant (+4) 0720 019 564 www.victorrentea.ro Follow me on Twitter <https://twitter.com/victorrentea>, LinkedIn <http://www.linkedin.com/in/victor-rentea-trainer> or Facebook <https://fb.me/VictorRentea.ro>! <https://ro.linkedin.com/in/victor-rentea-9339364a>

…

On Sun, Dec 6, 2020 at 3:10 PM lucianpalaghe ***@***.***> wrote: Rezolvarea mea la exercitiul lasat ca tema 🤓 ------------------------------ You can view, comment on, or merge this pull request online at: #2 Commit Summary - Remove arrays, move information to Player - Fix misspelled message, extract methods - Fix didPlayerWin method - Move Player class to its own file - Fix inPenaltyBox not being updated after player getting out of penalty box - Remove isGettingOutOfPenaltyBox - Remove isGettingOutOfPenaltyBox - Invert if for coect answers while in penalty box, cleanup File Changes - *M* src/main/java/victor/training/trivia/Game.java <https://github.com/victorrentea/clean-code-java/pull/2/files#diff-1b7c52fc4b63eb9dcc3a4067ad77a2caa4319f99b4f295b98c30cf95579dbeb8> (29) - *M* src/main/java/victor/training/trivia/GameBetter.java <https://github.com/victorrentea/clean-code-java/pull/2/files#diff-af8092fb50d1a24ed734b493748d110191e1916aab90845b62de28eb0c985f04> (124) - *M* src/main/java/victor/training/trivia/IGame.java <https://github.com/victorrentea/clean-code-java/pull/2/files#diff-96f4effc248eff30eb6261ffb894f81466a6cffb49c7874406dc39207ca9c80a> (5) - *A* src/main/java/victor/training/trivia/Player.java <https://github.com/victorrentea/clean-code-java/pull/2/files#diff-44ee00dffeadd607237e393460dd1b32c4205025ce7100d2c55cf12b9e377b2a> (51) - *M* src/test/java/trivia/GameTest.java <https://github.com/victorrentea/clean-code-java/pull/2/files#diff-221e738411da9b5eb7d05b0f9e05b5a1b59410fc4a1a7fea4cc230c376c8e757> (16) Patch Links: - https://github.com/victorrentea/clean-code-java/pull/2.patch - https://github.com/victorrentea/clean-code-java/pull/2.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC7HERXQ6IWVY4CFSVHKCJ3STN7DHANCNFSM4UPJ3CYA> .