Show all weeks and months in charts regardless of data#164
Open
MARMdeveloper wants to merge 2 commits intomainfrom
Open
Show all weeks and months in charts regardless of data#164MARMdeveloper wants to merge 2 commits intomainfrom
MARMdeveloper wants to merge 2 commits intomainfrom
Conversation
It is useful when the car is not used for weeks or months to maintain the same graph when making comparisons.
edc1171 to
df6f908
Compare
# Conflicts: # app/src/main/java/com/matedroid/ui/screens/charges/ChargesViewModel.kt
Collaborator
Author
|
Conflicts solved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the fix from #110 to also display all weeks (Last 90 days filter) and all months (Last year filter) in the charts, even when there's no data for those periods.
Previously, only the daily filters (Today, Last 7 days, Last 30 days) showed all days including empty ones. Now weekly and monthly views maintain consistency by showing complete periods.
Problem
When filtering by "Last 90 days" or "Last year", weeks or months without charges/drives were not displayed in the chart, making it difficult to:
Changes
Modified
calculateChartData()in bothChargesViewModelandDrivesViewModelto:For WEEKLY granularity:
For MONTHLY granularity:
Changes
ChargesViewModel.kt: UpdatedcalculateChartData()to handle WEEKLY and MONTHLY casesDrivesViewModel.kt: UpdatedcalculateChartData()to handle WEEKLY and MONTHLY casesBefore → After
Related