Conversation
- Rename recorder references to capture in CaptureClient - Bump videodb-capture-bin dependency to >=0.2.8 - Add channels, export_status, exported_videos to CaptureSession - Add displays property and export() method to CaptureSession - Fix generate_clip docstring return type to SearchResult - Bump version to 0.4.1
- Parse channels into typed VideoChannel/AudioChannel objects with store and is_primary attributes - Add displays property filtering by VideoChannel type - Add export() method with optional video_channel_id and connection_id for push notification on completion - Add primary_video_channel_id, export_status, exported_videos attributes from server API response
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f1f7397e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self, | ||
| capture_session_id: str, | ||
| channels: List[Channel], | ||
| primary_video_channel_id: Optional[str] = None, | ||
| ) -> None: |
There was a problem hiding this comment.
CaptureClient.start_session no longer accepts the previously supported primary_video_channel_id argument, so existing integrations that call start_session(..., primary_video_channel_id=...) now fail immediately with TypeError before any capture starts. Because this is a public SDK method and the release is a patch bump, this is a breaking runtime regression for callers that were valid in 0.4.0; keep the old kwarg (even as deprecated) and map it to the new primary-channel behavior.
Useful? React with 👍 / 👎.
…nection_id to ws_connection_id
3 participants
VideoDB SDK: Multi-Screen Capture & Export Support
Capture Binary & Session Updates
Multi-Screen Export
API Refinements