Open
Conversation
Contributor
Author
Let me test more rigorously before we merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description:
Add
get_embed_code()API across SDK objects to generate iframe embed HTML fromplayer_urlvalues, enabling users to easily share embeddable video players.Changes:
player_url_to_embed_url()utility to convert/watch?v=URLs to/embed?v=URLsbuild_iframe_embed_code()utility to generate iframe HTML stringsget_embed_code()method toVideo,Shot,SearchResultget_embed_code()method totimeline.Timeline,editor.Timelineget_embed_code()method toRTStreamShot,RTStreamExportResult,RTStreambuild_iframe_embed_codefromvideodbfor use with raw dict responsesVideo.generate_stream()to saveplayer_urlto instance (consistency with other classes)Related Issues:
Testing:
tests/test_embed_code.pycovering:player_url_to_embed_url()URL conversion and error casesbuild_iframe_embed_code()iframe generation with various parametersget_embed_code()method behavior on SDK objectsplayer_urlis unavailableUsage Examples: