Space suman#65
Open
suman111 wants to merge 4 commits intovidma:masterfrom
Open
Conversation
Owner
|
wow that's big! and exciting I hope!:) it would have been cool to separate into commits. at least the changes that are mechanic (autogen'ed files, moving thousands of images) could be separated. But I'll try to find time to take a look at this! Cheers |
Owner
|
finally found some time to take a look. some things noticed after playing shortly with
the rest looks 🆗. It's good to remove the what do you mean by |
Author
|
1. The white screen (permission is not granted) is because of the new
security update from android. In marshmallow and above android apps must
grant permission on starting of the app. I can fix it in next commit.
2. I don't know french or later anybody can add.
3. Check buttons in preferences menu is not working now.
It was a beta version, needed to do many works.
…On 9 April 2018 at 23:34, vidma ***@***.***> wrote:
finally found some time to take a look.
some things noticed after playing shortly with app-debug.apk :
- after installing it, screen stays white for very long until
extraction % status bar appears (maybe this is due to debug?)
- French language seems not to work anymore... !?
- clear search symbol (X) opens search
the rest looks 🆗. It's good to remove the history tab.
what do you mean by check buttons is not set ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOet1TFtSljPQILZ44nRgfm3EFTKdU2sks5tm6KVgaJpZM4Lq6Jx>
.
--
Regards,
Suman Dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
could you please go through this app and let us know if any modification needed?