feat: add bindSourceArgs and bindCuratorArgs utility functions#5
Merged
lambdalisue merged 3 commits intovim-fall:mainfrom Mar 4, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 50.63% 51.48% +0.85%
==========================================
Files 77 78 +1
Lines 2277 2317 +40
Branches 67 70 +3
==========================================
+ Hits 1153 1193 +40
Misses 1124 1124 ☔ View full report in Codecov by Sentry. |
07362c1 to
9c11bc6
Compare
Contributor
Author
|
Add missing export in deno.jsonc, and rebased the main branch. |
Add utility functions to create a new source/curator which calls another source/curator with some fixed args.
9c11bc6 to
f98e831
Compare
lambdalisue
requested changes
Feb 23, 2025
| return args instanceof Function ? await args(denops) : args; | ||
| } | ||
|
|
||
| export function bindSourceArgs<T extends Detail = Detail>( |
Member
There was a problem hiding this comment.
Please add documentation comment of the function.
Contributor
Author
|
Wrote documents. Also made the |
lambdalisue
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add utility functions,
bindSourceArgsandbindCuratorArgs, to create a new source or curator which calls another source or curator respectively with fixing the head n number of command-line arguments.For example, suppose if you have pickers defined like this,
then both
:Fall runtime-files-1and:Fall runtime-files-2will be equivalent to:Fall file $VIMRUNTIME.Plus, these utility functions does insert given arguments at the head of command-line arguments instead of replacing entire command-line arguments with given arguments, therefore
:Fall runtime-files-1 additional-argwill be equivalent to:Fall file $VIMRUNTIME additional-arg(thoughfilesource does not accept two or more arguments and this is not actually a valid command).