Add optional previewPath to file previewer#8
Merged
lambdalisue merged 1 commit intovim-fall:mainfrom Mar 30, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
- Coverage 51.48% 51.46% -0.03%
==========================================
Files 78 78
Lines 2317 2318 +1
Branches 70 70
==========================================
Hits 1193 1193
- Misses 1124 1125 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lambdalisue
requested changes
Mar 30, 2025
builtin/previewer/file.ts
Outdated
|
|
||
| type Detail = { | ||
| path: string; | ||
| preview_path?: string; |
Member
There was a problem hiding this comment.
Please use previewPath instead
71188a1 to
3f69a65
Compare
lambdalisue
approved these changes
Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional
previewPathproperty inDetail, which allows specifying a custom preview path for files.If the
previewPathis provided, it will be used for previewing the file.Otherwise, the
pathwill be used as a fallback.This change allows for scenarios where an item’s
pathis a directory. For example, when the path points to a directory, it enables the previewing of a specific file likeREADME.mdinside that directory.This update is backward compatible, so it won't affect existing functionality.
If there are existing features that can achieve the same functionality, please let me know.
The test coverage check is failing, but there are no similar tests for this change in the builtin extension, so I have left it on hold for now.