Removed mappings from the ScrollColor.vim plugin file.#1
Open
sanp wants to merge 1 commit intovim-scripts:masterfrom
Open
Removed mappings from the ScrollColor.vim plugin file.#1sanp wants to merge 1 commit intovim-scripts:masterfrom
sanp wants to merge 1 commit intovim-scripts:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mappings in this plugin have the potential to conflict with other mappings. In regular vim, you can probably resolve this by just adding
unmaps to your.vimrc. But for neovim users, since it loads plugins asynchronously, this doesn't work (the the plugin hasn't been loaded wheninit.vimis loaded, and so there is nothing forinit.vimto unmap).It's better to eliminate all mappings from plugins and let users create maps themselves. This PR does this.