Open
Conversation
Author
|
tarnfeld
added a commit
to tarnfeld/graph-explorer
that referenced
this pull request
Jul 8, 2014
|
This works for us on our pre-deployment environment. What's stopping it from being merged? |
Contributor
|
whoops, i somehow forgot about this one. |
Contributor
|
hmm pretty sure we use collectd 5.4.0, |
Author
|
collectd 5.1 from debian wheezy: |
|
Yeah, that's how it is for us too. Looks to me like this plugin handles both though? |
Author
|
exactly |
Contributor
There was a problem hiding this comment.
I think we should introduce a new unit for this, like Irq
Contributor
|
also using the phrase "fixes for collectd 5.x" is not really accurate, since apparantly it's only for older versions of 5.x (as they work for collectd 5.4) |
Contributor
|
Ping? If the things I mentioned could be fixed, that would make a nice PR. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collectd 5.x graphite_writer plugin produces metrics like:
collectd.host-1.memory.memory-buffered
collectd.host-1.df-root.df_complex-reserved
collectd.host-1.disk-dm-0.disk_octets.write
Original regexps doesn't match such metrics.