chore(deps): update go-github (major)#222
Merged
Merged
Conversation
Argo-Diff - Ephemeral Environment TestThis argo-diff should have the same output every run 3 of 3 apps with changes compared to live state 4:56PM UTC, 28 Jun 2026 === Basic-Deployment ===Synced ✅ ===== /ConfigMap basic-deployment/config-env =====--- /tmp/argocd-diff1817527430/config-env-live.yaml 2026-06-28 16:56:39.416309004 +0000
+++ /tmp/argocd-diff1817527430/config-env 2026-06-28 16:56:39.415309006 +0000
@@ -1,6 +1,6 @@
apiVersion: v1
data:
- HELLO_WORLD: test string
+ HELLO_WORLD: another test string
TZ: America/New_York
kind: ConfigMap
metadata:
===== apps/Deployment basic-deployment/test =====--- /tmp/argocd-diff3786189571/test-live.yaml 2026-06-28 16:56:39.426308980 +0000
+++ /tmp/argocd-diff3786189571/test 2026-06-28 16:56:39.426308980 +0000
@@ -5,6 +5,8 @@
argocd.argoproj.io/tracking-id: basic-deployment:apps/Deployment:basic-deployment/test
deployment.kubernetes.io/revision: "1"
generation: 1
+ labels:
+ app.kubernetes.io/name: argo-diff-test
managedFields:
- apiVersion: apps/v1
fieldsType: FieldsV1
@@ -77,6 +79,7 @@
selector:
matchLabels:
app: test
+ app.kubernetes.io/name: argo-diff-test
strategy:
rollingUpdate:
maxSurge: 25%
@@ -86,12 +89,13 @@
metadata:
labels:
app: test
+ app.kubernetes.io/name: argo-diff-test
spec:
containers:
- command:
- sh
- -c
- - while true ; do sleep 1; done
+ - while true ; do sleep 2; done
envFrom:
- configMapRef:
name: config-env
=== Meta ===Synced ✅ ===== argoproj.io/Application argocd/helm-deployment =====--- /tmp/argocd-diff2130436554/helm-deployment-live.yaml 2026-06-28 16:56:39.536308720 +0000
+++ /tmp/argocd-diff2130436554/helm-deployment 2026-06-28 16:56:39.536308720 +0000
@@ -143,10 +143,10 @@
- $values/test/helm-deployment.values.yaml
path: charts/test-basic-deployment
repoURL: https://github.com/vince-riv/argo-diff.git
- targetRevision: k3s-test
+ targetRevision: main
- ref: values
repoURL: https://github.com/vince-riv/argo-diff.git
- targetRevision: k3s-test
+ targetRevision: main
syncPolicy:
automated:
prune: true
=== Helm-Deployment ===Synced ✅ ===== /ConfigMap helm-deployment/config-env =====--- /tmp/argocd-diff530598828/config-env-live.yaml 2026-06-28 16:56:39.755308202 +0000
+++ /tmp/argocd-diff530598828/config-env 2026-06-28 16:56:39.755308202 +0000
@@ -1,6 +1,6 @@
apiVersion: v1
data:
- HELLO_WORLD: test string
+ HELLO_WORLD: another test string
TZ: America/New_York
kind: ConfigMap
metadata:
===== apps/Deployment helm-deployment/test =====--- /tmp/argocd-diff484295294/test-live.yaml 2026-06-28 16:56:39.766308176 +0000
+++ /tmp/argocd-diff484295294/test 2026-06-28 16:56:39.766308176 +0000
@@ -87,7 +87,7 @@
uid: 60b86525-e246-4580-9a0e-5af517822f80
spec:
progressDeadlineSeconds: 600
- replicas: 1
+ replicas: 2
revisionHistoryLimit: 10
selector:
matchLabels:
@@ -116,7 +116,7 @@
name: config-env
- secretRef:
name: test-secret
- image: busybox:latest
+ image: busybox:latest@sha256:1487d0af5f52b4ba31c7e465126ee2123fe3f2305d638e7827681e7cf6c83d5e
imagePullPolicy: IfNotPresent
name: test
resources: {}
|
dd86375 to
4fa0fd5
Compare
4fa0fd5 to
07bbd0d
Compare
07bbd0d to
48bc23e
Compare
go-github v87 changed NewClient() to return (*Client, error) and accept variadic ClientOptionsFunc instead of *http.Client. WithAuthToken is now a package-level option func rather than a method on *Client. Custom transports now use WithHTTPClient(). Tests updated to use WithURLs() in place of direct BaseURL/UploadURL field assignment.
48bc23e to
4739515
Compare
vrivellino
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v85.0.0→v88.0.0Release Notes
google/go-github (github.com/google/go-github/v85)
v88.0.0Compare Source
This release contains the following breaking API changes:
Find*methods toGet*(#4243)BREAKING CHANGE: App installation methods are renamed from
Find*toGet*....and the following additional changes:
openapi_operations.yaml(#4242)GetParentIssuefor sub-issues (#4232)v87.0.0Compare Source
This release contains the following breaking API changes:
GetConsumedLicensestoListConsumedLicenses(#4226)BREAKING CHANGE:
EnterpriseService.GetConsumedLicensesis nowEnterpriseService.ListConsumedLicenses.GetAllRepositoryRulesetstoListAllRepositoryRulesets(#4227)BREAKING CHANGE:
OrganizationsService.GetAllRepositoryRulesetsis nowOrganizationsService.ListAllRepositoryRulesets.GetRulesForBranchtoListRulesForBranch(#4229)BREAKING CHANGE:
RepositoriesService.GetRulesForBranchis nowRepositoriesService.ListRulesForBranch.BREAKING CHANGE: Clients are now constructed with a nicer builder pattern. See docs for details.
IssueFieldValueswith schema (#4207)BREAKING CHANGE:
IssueRequest.IssueFieldValuestype is changed....and the following additional changes:
MarshalJSON(#4211)httptestserver to prevent test flakiness (#4210)CodeSecurityConfiguration(#4205)go-githubfromv85tov86in /scrape (#4199)v86.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE: All internal calls now provide
Contextvia theRequestitself.PrivateRegistries(#4159)BREAKING CHANGE:
PrivateRegistriesServiceis updated to API version2026-03-10with struct and response changes....and the following additional changes:
go-githubtov86.0.0(#4198)otelmodule name (#4187)deploy_keys_enabled_for_repositoriesand secret scanning custom link fields toOrganizationstruct (#4188)testJSONBodyhelper for request body assertions in tests (#4183)RetryAfterinAbuseRateLimitError.Erroroutput (#4181)IDin Ruleset API responses (#4178)ArchivedAtfield toOrganizationstruct (#4179)Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate.