Skip to content

🐛 Fix empty path deletion on iOS #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinceglb merged 1 commit into from
Jul 9, 2026
+8 −0
Merged

🐛 Fix empty path deletion on iOS #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions filekit-core/src/appleMain/kotlin/io/github/vinceglb/filekit/utils/NSURLExt.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@ import platform.Foundation.NSURL

public fun NSURL.toKotlinxPath(): Path = this.path
?.let(::Path)
?: absoluteString
?.takeIf(String::isEmpty)
?.let(::Path)
?: throw FileKitNSURLNullPathException()
5 changes: 5 additions & 0 deletions filekit-core/src/nonWebTest/kotlin/io/github/vinceglb/filekit/PlatformFileNonWebTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ class PlatformFileNonWebTest {
assertTrue { resourceDirectory.exists() }
}

@Test
fun PlatformFile_deleteEmptyPathWithMustExistFalse_doesNothing() = runTest {
PlatformFile("").delete(mustExist = false)

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid running this iOS-only regression on JVM

This test lives in the shared nonWebTest source set, which is wired into jvmTest as well as native tests. On JVM, PlatformFile("") wraps java.io.File(""), i.e. the current working directory; because it exists, delete(mustExist = false) still attempts File.delete() and a non-empty checkout returns false, causing IOException("Deletion failed") and breaking :filekit-core:jvmTest/check. Please scope this regression to Apple/native or make JVM handle empty paths consistently before sharing the test.

Useful? React with 👍 / 👎.

}

@Test
fun testPlatformFileReadBytes() = runTest {
val textFileContent = textFile.readString()
Expand Down