payer_proof: replace recursive DFS with iterative DFS#85
payer_proof: replace recursive DFS with iterative DFS#85vincenzopalazzo merged 2 commits intomacros/proof-of-payment-bolt12-specfrom
Conversation
vincenzopalazzo
force-pushed
the
pr-84-fixup
branch
from
8f3c0ed to
3b001c4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b001c4025
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
vincenzopalazzo
force-pushed
the
pr-84-fixup
branch
from
3e3a996 to
c26f2b0
Compare
vincenzopalazzo
force-pushed
the
macros/proof-of-payment-bolt12-spec
branch
2 times, most recently
from
c62ce8b to
d186371
Compare
vincenzopalazzo
force-pushed
the
pr-84-fixup
branch
from
c26f2b0 to
df52660
Compare
vincenzopalazzo
force-pushed
the
macros/proof-of-payment-bolt12-spec
branch
from
d186371 to
022277d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df52660453
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Don't require payer proof missing hashes to remain TLV-sorted now that the spec uses DFS traversal order.
Embed the latest payer proof vectors and keep the test harness aligned with the current unsigned builder and signing flow.
vincenzopalazzo
force-pushed
the
pr-84-fixup
branch
from
5a7c167 to
7468188
Compare
2 participants
Summary
build_tree_dfs/reconstruct_dfswith iterative post-order DFS using an explicitDfsTaskstackroot_hash()and the rest of the merkle code in the offers modulemissing_hashesordering is identicalFixup for #84 (commit 3b77426).
Test plan
check_against_c_vectorspasses against C test vectorsCo-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com