Skip to content

Refactor associate user method in order model #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinay-mittal wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor associate user method in order model #134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4d3599
use update_columns instead of update_all
vinay-mittal Feb 24, 2016
051cce9
fix for new_record updation error
vinay-mittal Feb 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/app/models/spree/order.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def associate_user!(user, override_email = true)

# immediately persist the changes we just made, but don't use save
# since we might have an invalid address associated
self.class.unscoped.where(id: self).update_all(changes)
update_columns(changes) if persisted?
end

def quantity_of(variant, options = {})
Expand Down