Skip to content

Fix android readme configuration #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khaledab wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix android readme configuration #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ pod 'RNFileViewer', :path => '../node_modules/react-native-file-viewer'
1. Open up `android/app/src/main/java/[...]/MainApplication.java`

- Add `import com.vinzscam.reactnativefileviewer.RNFileViewerPackage;` to the imports at the top of the file
- Add `new RNFileViewerPackage()` to the list returned by the `getPackages()` method

2. Append the following lines to `android/settings.gradle`:

Expand All @@ -93,7 +92,7 @@ pod 'RNFileViewer', :path => '../node_modules/react-native-file-viewer'
3. Insert the following lines inside the dependencies block in `android/app/build.gradle`:

```
compile project(':react-native-file-viewer')
implementation project(':react-native-file-viewer')
```

4. Locate `react-native-file-viewer` inside `node_modules` folder and copy `android/src/main/res/xml/file_viewer_provider_paths.xml` to your project `res/xml/` directory
Expand Down