Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository to use the v5 major module path of github.com/gofrs/uuid, and adjusts CI to run with a newer Go toolchain.
Changes:
- Switch
gofrs/uuiddependency from v4 (+incompatible) togithub.com/gofrs/uuid/v5 v5.4.0ingo.mod/go.sum. - Update the
uuidimport path in the SQL test fixture to/v5. - Bump GitHub Actions Go version from
1.25to1.26.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
sqltest/fixture.go |
Updates import path to github.com/gofrs/uuid/v5. |
go.mod |
Moves dependency to github.com/gofrs/uuid/v5 v5.4.0. |
go.sum |
Updates checksums to match the new uuid v5 module. |
.github/workflows/go.yml |
Bumps CI Go toolchain version to 1.26. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "context" | ||
| "database/sql" | ||
| "fmt" | ||
| "github.com/gofrs/uuid" | ||
| "github.com/gofrs/uuid/v5" | ||
| mssql "github.com/microsoft/go-mssqldb" | ||
| "github.com/microsoft/go-mssqldb/msdsn" | ||
| "io/ioutil" |
There was a problem hiding this comment.
The import block is no longer gofmt-sorted/grouped (stdlib and third-party imports are interleaved). Please run gofmt on this file so imports are grouped and ordered consistently; this reduces merge churn and avoids style diffs later.
| uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: '1.25' | ||
| go-version: '1.26' |
There was a problem hiding this comment.
CI is now pinned to Go 1.26 while go.mod declares Go 1.25.7. If the project intends to support/build with the version in go.mod, consider using go-version-file: go.mod (or setting go-version to 1.25.x) so CI matches the module's declared minimum and avoids accidental version skew.
| go-version: '1.26' | |
| go-version-file: go.mod |
| uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: '1.25' | ||
| go-version: '1.26' |
There was a problem hiding this comment.
The PR title suggests this change is only about updating gofrs/uuid, but this workflow also bumps the Go toolchain version. If that upgrade is intentional, it would be clearer to mention it in the PR description/title; otherwise consider reverting the Go version change to keep the PR focused.
No description provided.